Uzbl

Tasklist

FS#219 - follow_hints and <button/>

Attached to Project: Uzbl
Opened by Kirikaza (kirikaza) - 2010-03-26 12:17:13 PM
Last edited by Brendan Taylor (bct) - 2010-11-26 07:45:03 PM
Task Type Bug Report
Category uzbl-core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version Development
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There is tag "button" and you can find it just in this bug-tracker =) Some changes ing follow.js are needed to support this tag:
--------------------------------------------------
@@ -138,6 +138,8 @@
} else {
item.click();
}
+ } else if (name == 'BUTTON') {
+ item.click();
} else if (name == 'TEXTAREA' || name == 'SELECT') {
item.focus();
item.select();
@@ -166,7 +168,7 @@
for (var f = 0; f < forms.length; f++) {
for (var e = 0; e < forms[f].elements.length; e++) {
var el = forms[f].elements[e];
- if (el && ['INPUT', 'TEXTAREA', 'SELECT'].indexOf(el.tagName) + 1 && isVisible(el) && elementInViewport(el)) {
+ if (el && ['INPUT', 'BUTTON', 'TEXTAREA', 'SELECT'].indexOf(el.tagName) + 1 && isVisible(el) && elementInViewport(el)) {
res[0].push(el);
}
}
--------------------------------------------------

Maybe this support is not complete but it works good enough.
This task depends upon

Closed by  Brendan Taylor (bct)
2010-11-26 07:45:03 PM
Reason for closing:  Implemented
Additional comments about closing:  thanks again!
Comment by Brendan Taylor (bct) - 2010-11-21 03:56:44 AM
thanks for the patch! commited on my branch: http://www.uzbl.org/bugs/index.php?do=details&task_id=219&project=1&status%5B0%5D=open
Comment by Brendan Taylor (bct) - 2010-11-26 07:44:37 PM
oops, that's not the right link obviously. it was added in commit 79bef7119a93081032e9a8f80c9f556c7d850467, which has been merged into Dieterbe's master and experimental branches.

Loading...