Uzbl

Tasklist

FS#300 - Makefile does not respect DESTDIR

Attached to Project: Uzbl
Opened by Tobias Rosenberger (son) - 2012-07-18 09:17:45 AM
Task Type Bug Report
Category building/dev environment
Status Unconfirmed
Assigned To No-one
Operating System Linux
Severity Low
Priority Normal
Reported Version Development
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I noticed the following bug in the Makefile:

The Makefile does not respect DESTDIR, to be precise, on my machine
$ make -j16 -s DESTDIR=/var/tmp/portage/www-client/uzbl-9999/image/ \
PREFIX=/usr \
DOCDIR=/var/tmp/portage/www-client/uzbl-9999/image//usr/share/doc/uzbl-9999 \
install-uzbl-core install-uzbl-browser install-uzbl-tabbed

tries to write to
"/usr/lib64/python3.2/site-packages/uzbl/event_manager.py".

This is fixed for me by the following patch:

From 6b942b1105896ba4d5d3c181352552d753240567 Mon Sep 17 00:00:00 2001
From: Tobias Rosenberger <TRosenberger@gmx.de>
Date: Tue, 3 Jul 2012 15:11:52 +0200
Subject: [PATCH] Made makefile respect DESTDIR

---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index e98a606..302660e 100644
--- a/Makefile
+++ b/Makefile
@@ -182,7 +182,7 @@ install-uzbl-core: uzbl-core install-dirs
install -m755 uzbl-core $(INSTALLDIR)/bin/uzbl-core

install-event-manager: install-dirs
- $(PYTHON) setup.py install --install-scripts=$(INSTALLDIR)/bin $(PYINSTALL_EXTRA)
+ $(PYTHON) setup.py install --prefix=$(INSTALLDIR) $(PYINSTALL_EXTRA)

install-uzbl-browser: install-dirs install-uzbl-core install-event-manager
sed 's#^PREFIX=.*#PREFIX=$(RUN_PREFIX)#' < bin/uzbl-browser > $(INSTALLDIR)/bin/uzbl-browser
--
1.7.8.6
This task depends upon

Comment by David Keijser (keis) - 2012-07-21 02:11:06 PM
Thanks. I'll look into this. I think that our setup call is a bit wrong in other ways to.

is the uzbl-9999 ebuild in some overlay or just plain portage?
Comment by Tobias Rosenberger (son) - 2012-07-21 08:17:03 PM
Just plain portage.
Comment by Noel Maersk (veox) - 2012-07-24 12:03:49 PM
Duplicate: FS#299
Comment by David Keijser (keis) - 2012-07-24 02:19:51 PM
using --root instead would still let distutils pick the correct prefix to use. If we use prefix you would have to install all of uzbl where python wants it.

I've got this change on a branch on github
git://github.com/keis/uzbl.git (fix/python-sandbox-path)
Comment by Tobias Rosenberger (son) - 2012-07-24 02:54:58 PM
Works for me,too.

Loading...